Sema: Fix checkTypeWitness() for Objective-C protocol compositions #71865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
AnthonyLatsis,
hborla and
xedin
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
I forgot that a protocol composition (C & P) can satisfy a superclass requirement [T : D] in one narrow case implemented in TypeBase::isExactSuperclassOf(): - D is a superclass of C - P is an @objc protocol - C is declared in Objective-C This case was ruled out here because the code assumed the type witness had to be a concrete class or archetype to satisfy a superclass requirement. Fixes rdar://problem/123543200.
slavapestov
force-pushed
the
fix-rdar123543200
branch
from
e687794 to
2befb08
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that a protocol composition
(C & P)can satisfy a superclass requirement[T : D]in one narrow case implemented in TypeBase::isExactSuperclassOf():This case was ruled out here because the code assumed the type witness had to be a concrete class or archetype to satisfy a superclass requirement.
Fixes rdar://problem/123543200.