Skip to content

Some create_benchmark.py script enhancements. #71867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

oscbyspro
Copy link
Contributor

This patch addresses some trials and tribulations I encountered in (#71786). It:

  1. fixes the auto-registration regex
  2. fixes the auto-generated array's name
  3. generates the current year for the license header
  4. generates some dashes for the license header

Short how-to per README.md

swift-source$ ./swift/benchmark/scripts/create_benchmark.py YourTestNameHere

This commit addresses some trials and tribulations I encountered while working on (swiftlang#71786). It:

1. fixes the auto-registration regex
2. fixes the auto-generated array's name
3. generates the current year for the license header
4. generates some dashes for the license header
Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@glessard
Copy link
Contributor

@swift-ci please smoke test

@glessard glessard enabled auto-merge February 24, 2024 20:33
This patch is held at linterpoint. Here's the ransom.
auto-merge was automatically disabled February 25, 2024 10:24

Head branch was pushed to by a user without write access

@oscbyspro
Copy link
Contributor Author

oscbyspro commented Feb 25, 2024

Looks like it is held at linterpoint. I've paid the ransom*.

*I downloaded PyCharm and asked it to reformat the parts I wrote.

@glessard
Copy link
Contributor

@swift-ci please smoke test

@glessard glessard enabled auto-merge February 25, 2024 19:00
@oscbyspro
Copy link
Contributor Author

@glessard can you ask @swift-ci to test it again? I doubt the failure on Windows has anything to do with this PR.

@glessard
Copy link
Contributor

glessard commented Mar 5, 2024

I didn't realize it hadn't gone through!

@glessard
Copy link
Contributor

glessard commented Mar 5, 2024

@swift-ci please test windows platform

@glessard glessard merged commit 3aea3a0 into swiftlang:main Mar 5, 2024
@oscbyspro oscbyspro deleted the better-create-benchmark-script branch March 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants