[DebugInfo] Fix dynamic self debug loc #71888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
felipepiovezan
force-pushed
the
felipe/dynamic_self_loc
branch
from
81b5866 to
a3e29ec
Compare
|
Added "requires concurrency" to test |
|
@swift-ci test |
felipepiovezan
force-pushed
the
felipe/dynamic_self_loc
branch
from
a3e29ec to
81c405b
Compare
|
@swift-ci test |
|
Added comment |
adrian-prantl
approved these changes
Feb 26, 2024
The instructions related to producing DynamicSelf metadata are always placed at the start of the function. This creates an issue: which debug location should be used in order to preserve a sane line table? The current implementation just uses w/e debug location is present in the new insertion point, which could, for example, be a debug_declare whose location is not suitable for these purposes. This patch addresses the issue by removing the debug location of instructions associated with producing DynamicSelfMetadata. rdar://120408665
felipepiovezan
force-pushed
the
felipe/dynamic_self_loc
branch
from
81c405b to
07d5895
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions related to producing DynamicSelf metadata are always placed at the start of the function. This creates an issue: which debug location should be used in order to preserve a sane line table? The current implementation just uses w/e debug location is present in the new insertion point, which could, for example, be a debug_declare whose location is not suitable for these purposes.
This patch addresses the issue by removing the debug location of instructions associated with producing DynamicSelfMetadata.
rdar://120408665