[ConstraintSystem] Skip sendability check for static members #71889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
angela-laar
reviewed
Feb 26, 2024
Such members only capture base metatatypes which are themselves always sendable.
xedin
force-pushed
the
static-members-are-always-sendable
branch
from
25dfce4 to
7c0bb41
Compare
|
@swift-ci please test |
hborla
reviewed
Feb 26, 2024
| if (isPartialApplication(locator) && baseOpenedTy->isSendableType()) { | ||
| if (isPartialApplication(locator) && | ||
| (resolvedBaseTy->is<AnyMetatypeType>() || | ||
| baseOpenedTy->isSendableType())) { |
There was a problem hiding this comment.
Why does isSendableType() return false for AnyMetatypeType? That seems like a problem
There was a problem hiding this comment.
It's not that, in this example Array.init has unbound generic parameters so if we were to use isSendableType on that it would crash.
There was a problem hiding this comment.
And baseOpenedTy is an instance type...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such members only capture base metatatypes which are themselves always sendable.