[Concurrency] Downgrade newly diagnosed distributed actor isolation violation as a warning until Swift 6. #71893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a warning until swift 6. In compiler versions <=5.10, the compiler did not diagnose cases where a non-isolated distributed actor value was passed to a VarDecl with a function type type that has an isolated distributed actor parameter, e.g. `(isolated DA) -> Void`. Stage in the error as a warning until Swift 6.
|
@swift-ci please smoke test |
ktoso
approved these changes
Feb 26, 2024
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compiler versions <=5.10, the compiler did not diagnose cases where a non-isolated distributed actor value was passed to a VarDecl with a function type type that has an isolated distributed actor parameter, e.g.
(isolated DA) -> Void. This code is problematic because the actor value is not known to be local, so onlydistributedfunctions may be called on it. This change stages in the error as a warning until Swift 6.Resolves: rdar://123536432