Skip to content

[Sema] Fix a syntax error when building without Swift Syntax #71894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

[Sema] Fix a syntax error when building without Swift Syntax #71894

merged 1 commit into from
Feb 27, 2024

Conversation

egorzhdan
Copy link
Contributor

There was a mismatched brace in a build where SWIFT_BUILD_SWIFT_SYNTAX is OFF.

@egorzhdan egorzhdan requested a review from ApolloZhu February 26, 2024 20:33
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan enabled auto-merge February 26, 2024 20:34
ApolloZhu
ApolloZhu approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@ApolloZhu ApolloZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 😅

@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

@egorzhdan egorzhdan merged commit f738cbc into main Feb 27, 2024
@egorzhdan egorzhdan deleted the egorzhdan/no-syntax branch February 27, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApolloZhu ApolloZhu ApolloZhu approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @ApolloZhu