Fix the TypeChecker's omitNeedlessWords to use interface types. #7193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...avoiding a crash when trying to detect near misses of protocol requirements. Unfortunately I can't come up with a test case for the VarDecl changes; everything I try seems to already work. But using interface types is more correct anyway. https://bugs.swift.org/browse/SR-3812
jrose-apple
force-pushed
the
omit-needless-types
branch
from
f0038a6 to
0127ded
Compare
|
@swift-ci Please smoke test |
|
Thanks. I have a fix for a similar problem in SILGen coming up. I started ripping out VarDecl::getType altogether, to avoid this type of breakage in the future. |
|
@kubamracek, what's up with the TSan test failure? |
|
|
Flaky test, I guess. By looking at test/Sanitizers/tsan.swift, I think we need to pthread_join the two threads, or the main thread can exit before one the new threads ever gets a chance to run. Which is what I guess happened here. |
|
I'll submit a PR to fix that. |
|
@swift-ci Please smoke test |
|
Would still like a quick glance from Doug, but going ahead based on Slava's review. |
|
LGTM, sorry for the delay |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Feb 2, 2017
…tlang#7193) ...avoiding a crash when trying to detect near misses of protocol requirements. Unfortunately I can't come up with a test case for the VarDecl changes; everything I try seems to already work. But using interface types is more correct anyway. https://bugs.swift.org/browse/SR-3812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...avoiding a crash when trying to detect near misses of protocol requirements. Unfortunately I can't come up with a test case for the VarDecl changes; everything I try seems to already work. But using interface types is more correct anyway.
SR-3812