[SourceKit] Only report textual results inside comments and strings from syntactic rename ranges #71966
+37
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
bnbarham
approved these changes
Feb 29, 2024
| // from the index. Since we don't, they are likely unrelated symbols that | ||
| // happen to have the same name. Don't return them as matching ranges. | ||
| // We only want to include these textual matches inside comments and string | ||
| // literals. All other matches inside are likely bugus results. |
There was a problem hiding this comment.
Suggested change
| // literals. All other matches inside are likely bugus results. | |
| // literals. All other matches inside are likely bogus results. |
Though I had a good laugh at bugus, I kind of like it.
|
@swift-ci please build toolchain macOS platform |
hamishknight
approved these changes
Feb 29, 2024
ahoppen
force-pushed
the
ahoppen/dont-rename-textual-code-results
branch
from
36ff5cf to
4f87317
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS |
…rom syntactic rename ranges
ahoppen
force-pushed
the
ahoppen/dont-rename-textual-code-results
branch
from
4f87317 to
63aeede
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.