Fix MetadataReader's isa-chasing on platforms that use indexed isa. #7199
Conversation
|
@swift-ci Please test. |
|
Starting tests, but I'm going to hold this until I see that it's fixing the armv7k problems on trunk. |
|
In the meantime, @slavapestov would you mind reviewing? |
|
Looks good, thanks! |
|
Looks like the trunk change did not fix the issue. Holding this for source updates. |
This is just implementing Greg Parker's spec for how to do it. rdar://29996920
…Shift. Unfortunately, I'm flying blind a bit --- this code is hard to test outside of an integrated environment on a target using the ABI in question, and I don't have such an environment set up --- so I'm left with this rather ugly process of iteratively submitting patches for trivial bugs and waiting for the bots to deliver judgment. The environment could be mocked with a test environment that used a nonstandard ObjC ABI, but that would actually take a lot of work because of Swift's assumptions about the ObjC ABI: we'd basically have to configure the test environment as a real, proper target, possibly all the way through LLVM.
rjmccall
force-pushed
the
indexed-isa-metadata-reader-3.1
branch
from
06c7c80 to
064ffc2
Compare
|
Bot finally came back clean on that test, so the new revision is good to go. @swift-ci Please test. |
|
Build failed |
|
Build failed |
|
@swift-ci Please test. |
|
Build failed |
This is just implementing Greg Parker's spec for how to do it.
rdar://29996920