Skip to content

[cxx-interop] Add conversions between std::chrono::duration and Swift.Duration #72012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

egorzhdan
Copy link
Contributor

rdar://123696734

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Mar 1, 2024
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners March 1, 2024 13:17
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan requested review from lorentey and phausler March 1, 2024 13:19
@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct to me.

@egorzhdan
Copy link
Contributor Author

Thanks @phausler for a quick review! :)

@egorzhdan egorzhdan merged commit f1adf99 into main Mar 1, 2024
@egorzhdan egorzhdan deleted the egorzhdan/std-chrono branch March 1, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants