Skip to content

test: Repair isolated_any_metadata.sil for Wasm CI #72013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 1, 2024

The test was failing on the Wasm CI because %IRGenFileCheck is configured for the target platform (in this case wasm32-unknown-wasi), but the test used it to check the output for other platforms. The mismatch was not revealed on the other CI because they are all 64-bit, but the 32-bit Wasm CI revealed it. https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/66/

Adjust a test case added by #71970 to repair Wasm CI

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 1, 2024 14:49
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@kateinoigakukun
Copy link
Member Author

@swift-ci Please test WebAssembly

The test was failing on the Wasm CI because `%IRGenFileCheck` is
configured for the target platform (in this case wasm32-unknown-wasi),
but the test used it to check the output for other platforms. The
mismatch was not revealed on the other CI because they are all 64-bit,
but the Wasm CI is 32-bit.
@kateinoigakukun kateinoigakukun force-pushed the yt/repair-isolated-any-wasm branch from 5885aa8 to 68f9c78 Compare March 1, 2024 16:15
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test WebAssembly

@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) March 1, 2024 18:15
@MaxDesiatov MaxDesiatov disabled auto-merge March 1, 2024 18:15
@MaxDesiatov MaxDesiatov enabled auto-merge (squash) March 1, 2024 18:16
@MaxDesiatov MaxDesiatov merged commit e7e5be1 into swiftlang:main Mar 1, 2024
@kateinoigakukun kateinoigakukun deleted the yt/repair-isolated-any-wasm branch March 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants