Move diagnostic about @_weakLinked not working for COFF into the type checker
#72015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
One less annoying thing for ASTGen to deal with! |
DougGregor
force-pushed
the
attr-weaklinked-coff-ifdef
branch
from
3d8001f to
521deca
Compare
|
@swift-ci please smoke test |
…pe checker This allows us to use `@_weakLinked` inside of a `#if` properly.
DougGregor
force-pushed
the
attr-weaklinked-coff-ifdef
branch
from
521deca to
ed6b713
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 1, 2024
lib/Sema/TypeCheckAttr.cpp
Outdated
Comment on lines
7346
to
7349
| if (Ctx.LangOpts.Target.isOSBinFormatCOFF()) { | ||
| diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target, | ||
| attr->getAttrName(), Ctx.LangOpts.Target.str()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (Ctx.LangOpts.Target.isOSBinFormatCOFF()) { | |
| diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target, | |
| attr->getAttrName(), Ctx.LangOpts.Target.str()); | |
| } | |
| if (!Ctx.LangOpts.Target.isOSBinFormatCOFF()) | |
| return; | |
| diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target, | |
| attr->getAttrName(), Ctx.LangOpts.Target.str()); |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
@_weakLinkedinside of a#ifproperly.