AST: Remove feature guards in .swiftinterfaces for syntax that has been parsable since Swift 5.8 #72025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove their explicit `UNINTERESTING_FEATURE` entries for them FeatureSet.cpp. All of these features have been present in the compiler since at least Swift 5.8. NFC.
It has been available since at least Swift 5.8.
…tures. They have been available since at least Swift 5.8.
tshortli
force-pushed
the
rebaseline-feature-set
branch
from
c241397 to
ba9b302
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to pollute
.swiftinterfacefiles with#if $Featureguards anymore for features that have been around awhile. I chose Swift 5.8 as the baseline for this cleanup.