[build-presets] Test SourceKit-LSP in the swift-syntax macOS job #72030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceKit-LSP depends on swift-syntax sufficiently much that changed runtime behavior of swift-syntax can make sourcekit-lsp fail, as it happened in swiftlang/sourcekit-lsp#1110. Only testing sourcekit-lsp on macOS, not Linux for now. Testing on one platform should be sufficient.
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 6, 2024
I added the test-sourcekit-lsp command because I thought that we weren’t running sourcekit-lsp tests on the swift-syntax PR testing job (swiftlang#72030). Then the job started failing with a TSAN failure and I thought that we would now not run sourcekit-lsp tests on the sourcekit-lsp PR testing job, so I added it there as well. Turns out that my first assumption that we weren’t running sourcekit-lsp tests on swift-syntax PRs was wrong and the downstream failure of that was just due to racing PRs. Furthermore, the `test-sourcekit-lsp` flag doesn’t even exist. Instead, it got typo-corrected (?) to `test-sourcekit-lsp-sanitize-all`, which enabled the TSAN sanitizer on the swift-syntax and sourcekit-lsp PR testing jobs. And that caused test failures. So, remove the `test-sourcekit-lsp` arguments again. After I made sourcekit-lsp build with strict concurrency / Swift 6 mode, I’ll re-enable TSAN on the sourcekit-lsp PR tests and fix any remaining TSAN issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceKit-LSP depends on swift-syntax sufficiently much that changed runtime behavior of swift-syntax can make sourcekit-lsp fail, as it happened in swiftlang/sourcekit-lsp#1110.
Only testing sourcekit-lsp on macOS, not Linux for now. Testing on one platform should be sufficient.