Implement proper visibility rules for imported extensions #72060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an extension isn't imported either directly or via a transitive (`@_exported`) import, its members should not be visible to name lookup. Implement this behavior behind the experimental flag ExtensionImportVisibility.
|
@swift-ci please smoke test |
This eliminates some diagnostics that incorrectly refer to a missin `@_spi` import as an outright missing import, which is incorrect. The one test case changed here really is a case of a missing import that happens to be SPI.
|
@swift-ci please smoke test |
tshortli
approved these changes
Apr 3, 2024
|
@swift-ci please smoke test |
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an extension isn't imported either directly or via a transitive (
@_exported) import, its members should not be visible to name lookup. Implement this behavior behind the experimental flag ExtensionImportVisibility.Addresses rdar://16154294 and #46493.