[Distributed] Emit accessors for distributed protocol requirements #72073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e underlying thunks Preparing to start emitting distributed requirement accessors that don't have `SILFunction *` because they are associated with protocol requirements.
…tocol requirements
Given the following protocol:
```
protocol Greeter : DistributedActor {
distributed func greet()
}
```
The changes make it possible to synthesize a distributed accessor
thunk for the requirement `greet` which would be dispatched to the
underlying concrete actor implementation at runtime.
…ould be backed by SILFunction Distributed protocol requirements don't have associated SILFunction, let's introduce a more flexible way to define it that collects only the information necessary for the function to become accessible.
…rotocol requirements
… `$` mangling This way distributed thunks could be formed in contexts that don't know what concrete actor they'd be dispatched to on the other side i.e. `distributed` members in protocol extensions should refer to protocol requirement accessors.
|
@swift-ci please test |
ktoso
reviewed
Mar 5, 2024
ktoso
reviewed
Mar 5, 2024
| auto emission = | ||
| getCallEmission(IGF, callee.getSwiftContext(), std::move(callee)); | ||
|
|
||
| emission->begin(); | ||
| emission->setArgs(arguments, /*isOutlined=*/false, | ||
| /*witnessMetadata=*/nullptr); | ||
| Target.getWitnessMetadata(actorSelf)); |
ktoso
approved these changes
Mar 5, 2024
…ObjC interop is disabled
xedin
force-pushed
the
distributed-protocol-requirement-accessors
branch
from
3525758 to
c00c692
Compare
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
|
We may need a clean build? |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
all tests passed but there was a merge conflict, I resolved it @swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Previous comment didn’t trigger CI for some reason. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following protocol:
The changes make it possible to synthesize a distributed accessor thunk for
the requirement
greetwhich would be dispatched to the underlyingconcrete actor implementation at runtime.