Skip to content

Make UnsafeRawBufferPointer.loadUnaligned inlinable to match other pointer load methods #72075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Catfish-Man
Copy link
Contributor

Fixes rdar://124038640 (UnsignedRawBufferPointer.loadUnaligned should be inlinable)

@Catfish-Man Catfish-Man requested a review from glessard March 5, 2024 00:04
@Catfish-Man Catfish-Man self-assigned this Mar 5, 2024
@Catfish-Man Catfish-Man requested a review from a team as a code owner March 5, 2024 00:04
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke benchmark

@Catfish-Man
Copy link
Contributor Author

I wonder if we have coverage for this…

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No good reason for omitting it from here.

@glessard glessard enabled auto-merge March 5, 2024 00:09
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test windows platform

@glessard glessard merged commit 8c0db3f into swiftlang:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants