Fixed issue #72085 where BinaryExpr fix-it suggested missing operator. #72090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyFanFan
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla and
xedin
as code owners
CrazyFanFan
force-pushed
the
fix/crazy_fan/72085
branch
from
ad3a1d1 to
ac1ac02
Compare
LucianoPAlmeida
approved these changes
Mar 9, 2024
ahoppen
reviewed
Mar 11, 2024
lib/Sema/CSDiagnostics.cpp
Outdated
| @@ -5863,12 +5863,16 @@ bool OutOfOrderArgumentFailure::diagnoseAsError() { | |||
|
|
|||
| // Move requires postfix comma only if argument is moved in-between | |||
| // other arguments. | |||
| bool requiresComma = | |||
| !isExpr<BinaryExpr>(anchor) && PrevArgIdx != args->size() - 1; | |||
| std::string sign; | |||
There was a problem hiding this comment.
Nitpick: I would call this argumentSeparator or something. But otherwise LGTM.
There was a problem hiding this comment.
Sure, it's all set to argumentSeparator. Thanks
CrazyFanFan
force-pushed
the
fix/crazy_fan/72085
branch
from
ac1ac02 to
b2c054a
Compare
xedin
approved these changes
Mar 12, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing operator to BinaryExpr fix-it suggestions.
Resolves #72085.