Skip to content

[AST/Sema] Distributed: Refactor type and member queries #72107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 6, 2024

  • Simplifies existing associated type handling logic
  • Introduces a unified way to retrieve serialization requirement for distributed actors
  • Moves some of the APIs out of ASTContext
  • Addresses some of the FIXMEs.

@xedin xedin marked this pull request as ready for review March 6, 2024 00:49
@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2024

@swift-ci please test

@xedin xedin changed the title [AST/Sema] Distributed: Factor type and member queries [AST/Sema] Distributed: Refactor type and member queries Mar 6, 2024
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup thank you!

ProtocolCompositionType::get(ctx, members,
/*inverses=*/{},
/*HasExplicitAnyObject=*/false));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2024

@swift-ci please test

@xedin xedin added the distributed Feature → concurrency: distributed actor label Mar 6, 2024
@xedin xedin force-pushed the rework-getting-types-from-system branch from 5a00add to 39efe5c Compare March 6, 2024 17:29
@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2024

@swift-ci please test

@xedin xedin force-pushed the rework-getting-types-from-system branch from 39efe5c to 1da0164 Compare March 6, 2024 23:03
@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2024

@swift-ci please smoke test

@xedin xedin merged commit d66eeae into swiftlang:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants