-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[AST/Sema] Distributed: Refactor type and member queries #72107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xedin
commented
Mar 6, 2024
- Simplifies existing associated type handling logic
- Introduces a unified way to retrieve serialization requirement for distributed actors
- Moves some of the APIs out of ASTContext
- Addresses some of the FIXMEs.
@swift-ci please test |
ktoso
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup thank you!
ProtocolCompositionType::get(ctx, members, | ||
/*inverses=*/{}, | ||
/*HasExplicitAnyObject=*/false)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@swift-ci please test |
5a00add
to
39efe5c
Compare
@swift-ci please test |
slavapestov
reviewed
Mar 6, 2024
…ion requirements for actors
…pressed through a conformance constraint
39efe5c
to
1da0164
Compare
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.