[stdlib] Start adopting noncopyable generics in the stdlib (phase 1) #72125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
added
the
swift evolution pending discussion
lorentey
changed the title
|
The |
|
@swift-ci please build toolchain macOS |
|
Test failures are down to 656 now (from 793 in #71688) -- still way too much for comfort. |
|
Symbol diffs as of 84983c6: |
|
Ah actually most of them are the |
lorentey
force-pushed
the
noncopyable-core-primitives
branch
2 times, most recently
from
9866c15 to
90df4f7
Compare
|
Ok, we're down to this symbol diff: |
|
@swift-ci please build toolchain macOS |
|
Remaining symbol mismatches: I think the solutions to these are beyond the stdlib. But this should get us to a somewhat workable state -- perhaps bootstrapping would work now. 🤔 |
|
@swift-ci please build toolchain macOS |
|
Test failures are slightly down, but not by much. Lots of reflection, interpreter, C++ interop issues. (Also the gtest unit tests are failing with linker errors about the missing ExpressibleByNilLiteral method descriptor.) |
lorentey
force-pushed
the
noncopyable-core-primitives
branch
from
b8bac2a to
dac90fd
Compare
|
With @DougGregor's fix from #72157, we've symbol parity with the mainline stdlib, and we're down to 55 test failures! (Actually 54 if we ignore my local python_lint failure.) The |
|
@swift-ci build toolchain macOS |
|
@swift-ci test |
|
The symbol mismatches in Synchronizaton are actually trivial -- the new |
|
The reflection tests are fixed by #72163 |
|
The C++ interop tests are fixed by #72165 |
|
@swift-ci test |
|
@swift-ci build toolchain macOS |
|
12 failures remaining! |
lorentey
force-pushed
the
noncopyable-core-primitives
branch
from
7cfe707 to
7c45076
Compare
|
@swift-ci build toolchain macOS |
1 similar comment
|
@swift-ci build toolchain macOS |
lorentey
force-pushed
the
noncopyable-core-primitives
branch
from
7c45076 to
a00565e
Compare
[stdlib] MemoryLayout: Update Swift version numbers [stdlib] MemoryLayout: Actually hide legacy ABI
… types [stdlib] Pull back @_aeic on pointer → integer conversions [stdlib] UnsafeMutablePointer.allocate: Fix thinko [stdlib] Disable support for noncopyable pointees on some pointer operations We have to temporarily pull back support for noncopyable pointees for UnsafeMutablePointer.initialize(to:), .moveInitialize, .moveUpdate, as the builtins they’re calling are no longer accepting such types. These will return following a builtin audit. [stdlib] Remove workarounds for certain builtins not supporting noncopyable use swiftlang#71733 fixed this! [stdlib] Update FIXME [stdlib] UnsafePointer: Update Swift version numbers [stdlib] UnsafePointer: Actually hide legacy ABI [stdlib] Remove workaround for U[M]BP.withMemoryRebound
- Enable BorrowingSwitch feature within the stdlib - ExpressibleByNilLiteral: Add retroactive support for noncopyable conforming types - Optional: draft an API surface for noncopyable payloads [stdlib] Oops, the ExpressibleByNilLiteral conformance kept its implicit copyability
…oolchain builds from succeeding
lorentey
force-pushed
the
noncopyable-core-primitives
branch
from
a00565e to
fb84071
Compare
|
@swift-ci build toolchain macOS |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci please test macOS platform |
|
Closing. Work is ongoing over in #71688. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #71688 that concentrates on the basics:
MemoryLayoutUnsafePointerUnsafeMutablePointerOptionalExpressibleByNilLiteral