Skip to content

[transferring] When transforming an AST function type into its lowered form, make sure transferring result is propagated. #72132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[transferring] When transforming an AST function type into its lowered form, make sure transferring result is propagated. #72132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/SIL/IR/SILFunctionType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4714,6 +4714,9 @@ TypeConverter::getLoweredFormalTypes(SILDeclRef constant,
bridgedParams.push_back(selfParam);
}

if (innerExtInfo.hasTransferringResult())
extInfo = extInfo.withTransferringResult();

auto uncurried = CanAnyFunctionType::get(
genericSig, llvm::ArrayRef(bridgedParams), bridgedResultType, extInfo);

Expand Down
121 changes: 121 additions & 0 deletions test/SILGen/transferring.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
// RUN: %target-swift-emit-silgen -disable-availability-checking -enable-upcoming-feature RegionBasedIsolation -enable-experimental-feature TransferringArgsAndResults -strict-concurrency=complete %s | %FileCheck %s

class NonSendable {}

// CHECK-LABEL: sil hidden [ossa] @$s12transferring15returnsSendableSSyYTF : $@convention(thin) () -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring18returnsNonSendableAA0cD0CyYTF : $@convention(thin) () -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring25genericReturnsNonSendablexyYTlF : $@convention(thin) <T> () -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }

actor MyActor {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring7MyActorC15returnsSendableSSyYTF : $@convention(method) (@sil_isolated @guaranteed MyActor) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring7MyActorC18returnsNonSendableAA0eF0CyYTF : $@convention(method) (@sil_isolated @guaranteed MyActor) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring7MyActorC25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (@sil_isolated @guaranteed MyActor) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

struct Struct {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV15returnsSendableSSyYTF : $@convention(method) (Struct) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV18returnsNonSendableAA0dE0CyYTF : $@convention(method) (Struct) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (Struct) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

@MainActor
struct MainActorStruct {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring15MainActorStructV15returnsSendableSSyYTF : $@convention(method) (MainActorStruct) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring15MainActorStructV18returnsNonSendableAA0fG0CyYTF : $@convention(method) (MainActorStruct) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring15MainActorStructV25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (MainActorStruct) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

class Class {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring5ClassC15returnsSendableSSyYTF : $@convention(method) (@guaranteed Class) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring5ClassC18returnsNonSendableAA0dE0CyYTF : $@convention(method) (@guaranteed Class) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring5ClassC25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (@guaranteed Class) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

final class FinalClass {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring10FinalClassC15returnsSendableSSyYTF : $@convention(method) (@guaranteed FinalClass) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring10FinalClassC18returnsNonSendableAA0eF0CyYTF : $@convention(method) (@guaranteed FinalClass) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring10FinalClassC25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (@guaranteed FinalClass) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

@MainActor
class MainActorClass {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring14MainActorClassC15returnsSendableSSyYTF : $@convention(method) (@guaranteed MainActorClass) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring14MainActorClassC18returnsNonSendableAA0fG0CyYTF : $@convention(method) (@guaranteed MainActorClass) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring14MainActorClassC25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (@guaranteed MainActorClass) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

@MainActor
final class FinalMainActorClass {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring19FinalMainActorClassC15returnsSendableSSyYTF : $@convention(method) (@guaranteed FinalMainActorClass) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring19FinalMainActorClassC18returnsNonSendableAA0gH0CyYTF : $@convention(method) (@guaranteed FinalMainActorClass) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring19FinalMainActorClassC25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (@guaranteed FinalMainActorClass) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

enum Enum {
case myCase
// CHECK-LABEL: sil hidden [ossa] @$s12transferring4EnumO15returnsSendableSSyYTF : $@convention(method) (Enum) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring4EnumO18returnsNonSendableAA0dE0CyYTF : $@convention(method) (Enum) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring4EnumO25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (Enum) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

@MainActor
enum MainActorEnum {
case myCase
// CHECK-LABEL: sil hidden [ossa] @$s12transferring13MainActorEnumO15returnsSendableSSyYTF : $@convention(method) (MainActorEnum) -> transferring @owned String {
func returnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring13MainActorEnumO18returnsNonSendableAA0fG0CyYTF : $@convention(method) (MainActorEnum) -> transferring @owned NonSendable {
func returnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring13MainActorEnumO25genericReturnsNonSendablexyYTlF : $@convention(method) <T> (MainActorEnum) -> transferring @out T {
func genericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

protocol P {
func protReturnsSendable() -> transferring String
func protReturnsNonSendable() -> transferring NonSendable
func protGenericReturnsNonSendable<T>() -> transferring T
}

extension P {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring1PPAAE19protReturnsSendableSSyYTF : $@convention(method) <Self where Self : P> (@in_guaranteed Self) -> transferring @owned String {
func protReturnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring1PPAAE22protReturnsNonSendableAA0dE0CyYTF : $@convention(method) <Self where Self : P> (@in_guaranteed Self) -> transferring @owned NonSendable {
func protReturnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring1PPAAE29protGenericReturnsNonSendableqd__yYTlF : $@convention(method) <Self where Self : P><T> (@in_guaranteed Self) -> transferring @out T {
func protGenericReturnsNonSendable<T>() -> transferring T { fatalError() }
}

extension Struct : P {
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV19protReturnsSendableSSyYTF : $@convention(method) (Struct) -> transferring @owned String {
func protReturnsSendable() -> transferring String { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV22protReturnsNonSendableAA0eF0CyYTF : $@convention(method) (Struct) -> transferring @owned NonSendable {
func protReturnsNonSendable() -> transferring NonSendable { fatalError() }
// CHECK-LABEL: sil hidden [ossa] @$s12transferring6StructV29protGenericReturnsNonSendablexyYTlF : $@convention(method) <T> (Struct) -> transferring @out T {
func protGenericReturnsNonSendable<T>() -> transferring T { fatalError() }
}