[TBDGen][Test] Check implied Obj-C symbol generation based on a stable swift version #72138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
approved these changes
Mar 7, 2024
cyndyishida
force-pushed
the
eng/PR-updatesymbolsTestYetAgain
branch
from
93a81a5 to
1a6dfca
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously thought the coupled
OBJC_CLASS | OBJC_METACLASSwas specific to iOS, but it actually seems tied to compiling for deployment versions lower than when swift was shipped with darwin OSes. The test has been updated to use a recent-ish target triple across all CI configurations, where both symbols get emitted.