[region-isolation] Simplify the code for use after transfer errors. #72140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we previously would generate a list of errors to emit and then have one centralized piece of code that went through the list and emitted them. Instead, we now have a low level emitter struct that is just used to emit the diagnostic at the immediate point where we would create previously an error record. This places the diagnostic emission next to the piece of code that triggered it being emitted making it easier to debug why an error was emitted using -Xllvm -swift-diagnostics-assert-on-*. I am going to do the same for transfer non transferrable in a little bit once the async let patch has landed. It has some transfer non transferable error additions that I want to get in so I am going to wait on that. NFCI.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we previously would generate a list of errors to emit and then have one centralized piece of code that went through the list and emitted them. Instead, we now have a low level emitter struct that is just used to emit the diagnostic at the immediate point where we would create previously an error record. This places the diagnostic emission next to the piece of code that triggered it being emitted making it easier to debug why an error was emitted using -Xllvm -swift-diagnostics-assert-on-*.
I am going to do the same for transfer non transferrable in a little bit once the async let patch has landed. It has some transfer non transferable error additions that I want to get in so I am going to wait on that.
NFCI.