[Concurrency] Improve the diagnostics for unsafe immutable global and static variables. #72147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static variables.
|
@swift-ci please smoke test |
ktoso
reviewed
Mar 7, 2024
| .warnUntilSwiftVersion(6); | ||
| diagVar->diagnose(diag::shared_immutable_state_decl_note, |
There was a problem hiding this comment.
Not blocking merging: worth a fixme to add Sendable? 🤔
ktoso
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current diagnostic is a little hard to mentally parse, and folks seem to be confused specifically when the global variable is a
letconstant. This changes the diagnostic to state that the non-Sendabletype may have shared mutable state, and moves the potential resolutions to an attached note.