[Distributed][Macro] Handle more cases in distributed protocol macro #72177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-distributed-macro-fixes
branch
2 times, most recently
from
ab06f36 to
99450d7
Compare
|
@swift-ci please smoke test |
We may have a valid distributed actor stub without where requirement if a typealias was used;
ktoso
force-pushed
the
wip-distributed-macro-fixes
branch
from
99450d7 to
09298ae
Compare
|
@swift-ci please smoke test |
|
Lots of cleanups to the macros, thanks to landing all our previous changes 👍 |
ktoso
commented
Mar 11, 2024
xedin
reviewed
Mar 11, 2024
|
|
||
| @_DistributedProtocol | ||
| protocol Greeter: DistributedActor where ActorSystem == FakeActorSystem { | ||
| distributed func greet(name: String) -> String |
There was a problem hiding this comment.
I'm just going to leave an enhancement request here - I think we need to get tested at least:
- methods with generic parameters
- distributed variables i.e. protocol requirements like
distributed var compute: Int { get set } - Multiple distributed members
There was a problem hiding this comment.
Good call on properties actually, I don't think we roundtrip tested them yet
There was a problem hiding this comment.
Covered all these and will add runtime tests as well in a follow up PR
xedin
reviewed
Mar 11, 2024
xedin
approved these changes
Mar 11, 2024
ktoso
force-pushed
the
wip-distributed-macro-fixes
branch
from
09298ae to
f7b27ec
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed protocol macro was blocked from generating the full right thing until we fixed generic actors and protocols and the Codable actor behaviors.
A few more cases to be handled here.