Skip to content

[Bridging PCH] Teach SourceKit to ignore the bridging-pch driver options #7218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Feb 3, 2017

master-directed copy of #7217, original description follows:

SourceKit unfortunately gets upset when users pass -{enable,disable}-bridging-pch via OTHER_SWIFT_FLAGS. This patch adds these driver-only options to SourceKit's local
ignore-list.

rdar://30342040

@graydon graydon requested a review from benlangmuir February 3, 2017 01:17
@graydon
Copy link
Contributor Author

graydon commented Feb 3, 2017

@swift-ci please smoke test

@graydon graydon merged commit ceaa4a9 into swiftlang:master Feb 3, 2017
@graydon graydon deleted the sourcekit-ignore-bridging-pch branch September 13, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants