Skip to content

[5.10] Tests: mark armv7k as unsupported for lto_autolink.swift #72189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Mar 8, 2024

This test also fails on armv7k. Addressing the failure on 5.10 first as the corresponding bot on main fails earlier.

Followup to #72167
rdar://122672371

@xymus xymus requested a review from tshortli March 8, 2024 17:47
@xymus xymus requested a review from a team as a code owner March 8, 2024 17:47
@xymus
Copy link
Contributor Author

xymus commented Mar 8, 2024

@swift-ci please test

@@ -63,6 +63,6 @@ import AutolinkModuleMapLink
#endif

// UNSUPPORTED: OS=macosx && CPU=arm64
// UNSUPPORTED: OS=ios && CPU=arm64e
// UNSUPPORTED: OS=ios && (CPU=arm64e || CPU=armv7k)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought armv7k was a watchOS architecture. There are configurations where we compile for armv7k and iOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, it was watchos-armv7k. I'll update this.

@xymus xymus force-pushed the lto_autolink-armv7k-5.10 branch from 9866c83 to 2331725 Compare March 8, 2024 18:14
@xymus
Copy link
Contributor Author

xymus commented Mar 8, 2024

@swift-ci Please test

@xymus xymus merged commit c2ca810 into swiftlang:release/5.10 Mar 8, 2024
@xymus xymus deleted the lto_autolink-armv7k-5.10 branch March 8, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants