[IRGen] Collect metadata for empty fields. #72210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debug builds, provide some context when a witness table fails to be found.
Previously, when the metadata collector only collected for layout, it was wasteful to visit the empty fields of records. Now that the field may require a deinit call, it's necessary to visit it. rdar://123577998
nate-chandler
force-pushed
the
rdar123577998
branch
from
586dc44 to
34dd4aa
Compare
|
@swift-ci please test |
nate-chandler
changed the title
nate-chandler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the metadata collector only collected for layout, it was wasteful to visit the empty fields of records. Now that the field may require a deinit call, it's necessary to visit it.
rdar://123577998