IRGen: Add code to support building fragile resilient protocol witnesses #72218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't currently support building resilient relative protocol witness tables. One might want to build with relative witness tables but not need resilient protocols. Allow for that scenario. Add a test configuration to test library-evolution + fragile resilient protocols + relative protocol witness tables.
aschwaighofer
requested review from
a team,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
aschwaighofer
commented
Mar 10, 2024
| @@ -2528,6 +2532,16 @@ void IRGenModule::emitSILWitnessTable(SILWitnessTable *wt) { | |||
| bool isResilient = isResilientConformance(conf); | |||
| bool useRelativeProtocolWitnessTable = | |||
| IRGen.Opts.UseRelativeProtocolWitnessTables; | |||
| if (useRelativeProtocolWitnessTable && | |||
There was a problem hiding this comment.
@slavapestov I am trying to test for variadic generics with conditional conformances here. Probably, doing it all wrong?
There was a problem hiding this comment.
Well, for one a dump() isn't going to fly in an no-asserts build ...
|
@swift-ci test |
slavapestov
approved these changes
Mar 10, 2024
lib/IRGen/GenProto.cpp
Outdated
| if (useRelativeProtocolWitnessTable && | ||
| !conf->getConditionalRequirements().empty()) { | ||
| auto nominal = conf->getType()->getAnyNominal(); | ||
| auto sig = nominal->getGenericSignatureOfContext(); |
There was a problem hiding this comment.
This should work too: sig = conf->getGenericSignature();
| @@ -2528,6 +2532,16 @@ void IRGenModule::emitSILWitnessTable(SILWitnessTable *wt) { | |||
| bool isResilient = isResilientConformance(conf); | |||
| bool useRelativeProtocolWitnessTable = | |||
| IRGen.Opts.UseRelativeProtocolWitnessTables; | |||
| if (useRelativeProtocolWitnessTable && | |||
|
@swift-ci test |
|
@swift-ci test |
kalebers
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently support building resilient relative protocol witness tables. One might want to build with relative witness tables but not need resilient protocols. Allow for that scenario.
Add a test configuration to test library-evolution + fragile resilient protocols + relative protocol witness tables.