Skip to content

Initial support work for Package CMO #72249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Initial support work for Package CMO #72249

merged 1 commit into from
Mar 13, 2024

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Mar 12, 2024

  • Add a new flag -experimental-package-cmo that requires -experimental-allow-non-resilient-access.
  • Support serializing package decls for CMO in package if enabled.
  • Only applies to default mode CMO.
  • Unlike the existing CMO, package CMO can be built with -enable-library-evolution as package
    modules are required to be built together in the same project.
  • Create hasPublicOrPackageVisibility to opt in for package decls; needed for CMO, SILVerifier,
    and other call sites that verify or determine codegen.

Resolves rdar://121976014

@elsh
Copy link
Contributor Author

elsh commented Mar 12, 2024

@swift-ci test

@xedin xedin removed their request for review March 12, 2024 17:01
* Add a new flag -experimental-package-cmo that requires -experimental-allow-non-resilient-access.
* Support serializing package decls for CMO in package if enabled.
* Only applies to default mode CMO.
* Unlike the existing CMO, package CMO can be built with -enable-library-evolution as package
modules are required to be built together in the same project.
* Create hasPublicOrPackageVisibility to opt in for package decls; needed for CMO, SILVerifier,
and other call sites that verify or determine codegen.

Resolves rdar://121976014
@elsh
Copy link
Contributor Author

elsh commented Mar 12, 2024

@swift-ci smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elsh elsh merged commit 56d337d into main Mar 13, 2024
@elsh elsh deleted the es/pkg-cmo branch March 13, 2024 16:26
@elsh elsh changed the title Support Package CMO Initial support work for Package CMO May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants