Concurrency: Guard use of withoutActuallyEscaping() in inlinable code
#72259
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
force-pushed
the
typed-throws-without-actually-escaping
branch
from
70a780d to
40c1a3c
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
Mar 12, 2024
Since `withoutActuallyEscaping()` has adopted typed throws, it's no longer visible to older compilers that do not support typed throws. We need to guard use of the function in inlinable code to make sure the textual interface of `_Concurrency` remains buildable with older compilers. Resolves rdar://124352900
tshortli
force-pushed
the
typed-throws-without-actually-escaping
branch
from
40c1a3c to
65c0ef8
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
withoutActuallyEscaping()has adopted typed throws, it's no longer visible to older compilers that do not support typed throws. We need to guard use of the function in inlinable code to make sure the textual interface of_Concurrencyremains buildable with older compilers.Resolves rdar://124352900