[Index] Scope the setting of IgnoreAdjacentModules
#72275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't _think_ this currently causes any issues, but make sure we unset `IgnoreAdjacentModules` when done loading the module.
hamishknight
requested review from
ahoppen,
bnbarham and
rintaro
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Mar 13, 2024
xymus
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
If we expect to keep loading modules after this step, reverting that setting may not have the full expected impact. With the current logic we force reloading modules from swiftinterfaces by ignoring the cache, but I believe these modules once loaded still get cached. I would expect them to end up overriding the loaded adjacent swiftmodules. So subsequent module loading may pick the module built from swiftinterface even with setIgnoreAdjacentModules = false. That should be safe, in theory at least, and I don't think we load anything after this step so I'm fine with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this currently causes any issues, but make sure we unset
IgnoreAdjacentModuleswhen done loading the module.