[Archetype builder] Suppress redundant constraints more effectively. #7228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a couple of places where we were not managing to consider redundant constraints as 'redundant', so the canonicalized generic signatures were not in fact minimal. Address this in several places: * When a type is made concrete, any superclass requirements on it are redundant * When a type is made concrete, any same-type relationships among its nested types are redundant * Only emit potential-archetype-to-concrete constraints in the resulting signature for the component anchors; not for every type. The first two bullets were existing problems that are now fixed; the last is something I appear to have introduced with last week's refactoring of canonicalized same-type constraints. The recent work to make the canonicalization deterministic exacerbated the issue considerably, leading to huge blow-up in the size of canonical generic signatures that cost ~100k in standard library size. This change recovers that 100k.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of places where we were not managing to consider
redundant constraints as 'redundant', so the canonicalized generic
signatures were not in fact minimal. Address this in several places:
redundant
nested types are redundant
resulting signature for the component anchors; not for every type.
The first two bullets were existing problems that are now fixed; the
last is something I appear to have introduced with last week's
refactoring of canonicalized same-type constraints.
The recent work to make the canonicalization deterministic exacerbated
the issue considerably, leading to huge blow-up in the size of
canonical generic signatures that cost ~100k in standard library
size. This change recovers that 100k.