SIL: Optimizer fixes for noncopyable optional chains. #72281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't attempt a SILCombine transform on `select_enum` that inserts a copy when an enum is noncopyable. Adjust the cleanup handling for a consuming optional chain to ensure a `destroy_value` still gets emitted on the `none` path; this shouldn't actually matter since `none` is a trivial case, but the memory verifier isn't that fancy during OSSA, and we can optimize it later. Fixes rdar://124426918.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't attempt a SILCombine transform on
select_enumthat inserts a copy when an enum is noncopyable. Adjust the cleanup handling for a consuming optional chain to ensure adestroy_valuestill gets emitted on thenonepath; this shouldn't actually matter sincenoneis a trivial case, but the memory verifier isn't that fancy during OSSA, and we can optimize it later. Fixes rdar://124426918.