Fixes package import stmt missing from .package.swiftinterface. #72282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
xymus
reviewed
Mar 13, 2024
xymus
reviewed
Mar 13, 2024
xymus
reviewed
Mar 13, 2024
elsh
force-pushed
the
elsh/pkg-import-pkg-interface
branch
from
8ff9ef8 to
e9cab7a
Compare
elsh
commented
Mar 13, 2024
elsh
commented
Mar 13, 2024
elsh
commented
Mar 13, 2024
|
@swift-ci smoke test |
Resolves rdar://124309585
elsh
force-pushed
the
elsh/pkg-import-pkg-interface
branch
from
e9cab7a to
2d90423
Compare
|
@swift-ci smoke test |
xymus
reviewed
Mar 13, 2024
| @@ -332,7 +349,7 @@ static void printImports(raw_ostream &out, | |||
| out << "@_implementationOnly "; | |||
| } | |||
|
|
|||
| if (publicImportSet.count(import)) | |||
| if (exportedImportSet.count(import)) | |||
There was a problem hiding this comment.
That rename was long overdue, thanks!
xymus
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://124309585