[embedded] Start building Synchronization in embedded Swift mode #72293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
phausler,
stephentyrone,
rauhul,
zoecarver and
eeckstein
rauhul
approved these changes
Mar 13, 2024
kubamracek
force-pushed
the
embedded-synchronization
branch
from
d2e98e9 to
48b8228
Compare
Azoy
approved these changes
Mar 13, 2024
|
@swift-ci please test |
This was referenced Mar 14, 2024
drodriguez
added a commit
that referenced
this pull request
Mar 16, 2024
#72356) PR #72293 added the synchronization module to embedded, and it was added as dependency of `ALL`, but not of the `-test-depends` targets. If one is using the `-test-depends` targets, the synchronization library for embedded will not be build, and the test will fail. This is a follow up to #72329. I had a partial build to test that, and I did not notice this was also missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward enablement of the Synchronization module for Embedded Swift. It turns out that this module doesn't depend on anything else than the Builtin module. The atomic builtins only have a dependency on compiler-rt, and we have already passed that bridge with the atomic refcounting in the embedded runtime.