stdlib: Guard @inlinable use of withMemoryRebound() with #if $TypedThrows
#72301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pedThrows`. Older compilers can no longer see the definition of `withMemoryRebound()` now that it has adopted typed throws (swiftlang#72036). Resolves rdar://124540428
|
@swift-ci please smoke test |
glessard
reviewed
Mar 13, 2024
There was a problem hiding this comment.
I see that you went much further in the #else case in this commit. Is fatalError() sufficient?
glessard
approved these changes
Mar 13, 2024
When there is a reasonable fallback we might as well call it to be more forgiving to the code built by older compilers. But we don't appear to have a simple fallback option in this case so I just went with fatalError and hope the code built in this configuration does not need these functions. |
|
OK. Now that I've been alerted I'll add the fallbacks in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older compilers can no longer see the definition of
withMemoryRebound()now that it has adopted typed throws (#72036).Resolves rdar://124540428