Skip to content

Tests: un-xfail tests on the freestanding bot #72306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Tests: un-xfail tests on the freestanding bot #72306

merged 1 commit into from
Mar 14, 2024

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Mar 13, 2024

Un-xfailing tests fixed by #72283.

Three tests are still failing:

stdlib/freestanding-check-symbols.test-sh
Concurrency/optional_isolated_parameters.swift
Concurrency/ShrinkWrap.swift

@xymus xymus requested review from phausler and rokhinip March 13, 2024 20:34
@xymus xymus requested review from a team and ktoso as code owners March 13, 2024 20:34
@xymus
Copy link
Contributor Author

xymus commented Mar 13, 2024

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@xymus
Copy link
Contributor Author

xymus commented Mar 13, 2024

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Mar 14, 2024

There's one failure remaining that wasn't part of the xfail. Concurrency/async_main.swift

@xymus xymus merged commit e929235 into swiftlang:main Mar 14, 2024
@xymus xymus deleted the revert-xfail-freestanding branch March 14, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler Awaiting requested review from phausler

@rokhinip rokhinip Awaiting requested review from rokhinip

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xymus