[Concurrency] Add a .isolation member on dynamically isolated function values.
#72324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation of a dynamically isolated function value in the AST.
…ically isolated function values.
hborla
requested review from
ktoso,
xedin,
slavapestov,
ahoppen,
bnbarham,
hamishknight,
rintaro and
tshortli
as code owners
|
@swift-ci please smoke test |
xedin
reviewed
Mar 14, 2024
| // member that extracts the isolation value. | ||
| if (auto *fn = dyn_cast<FunctionType>(instanceTy)) { | ||
| if (fn->getIsolation().isErased() && | ||
| memberName.getBaseIdentifier().str() == "isolation") { |
There was a problem hiding this comment.
I think memberName.isSimpleName(Context.Id_isolation) could be used here
| @@ -9746,6 +9747,16 @@ performMemberLookup(ConstraintKind constraintKind, DeclNameRef memberName, | |||
| if (auto *selfTy = instanceTy->getAs<DynamicSelfType>()) | |||
| instanceTy = selfTy->getSelfType(); | |||
|
|
|||
| // Dynamically isolated function types have a magic '.isolation' | |||
| // member that extracts the isolation value. | |||
| if (auto *fn = dyn_cast<FunctionType>(instanceTy)) { | |||
There was a problem hiding this comment.
Maybe better use instanceTy->getAs<FunctionType>() because member could be wrapped in parens
|
|
||
| func extractFunctionIsolationExpr( | ||
| _ fn1: @isolated(any) @escaping () async -> Void, | ||
| _ fn2: @isolated(any) @escaping (Int, String) -> Bool |
There was a problem hiding this comment.
Could you please add a few test-cases that deal with optional unwrap (both styles) as well?
angela-laar
pushed a commit
to angela-laar/swift
that referenced
this pull request
Mar 15, 2024
…tion-expr [Concurrency] Add a `.isolation` member on dynamically isolated function values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the
.isolationmember on function values with dynamically isolated function type. The approach is very straightforward:isolationon function types with erased isolation and records a specialExtractFunctionIsolationoverload choice.ExtractFunctionIsolationoverload choice is selected, CSApply injectsExtractFunctionIsolationExpraround the function expression.function_extract_isolationinstruction.The
.isolationmember is equivalent to theextractFunctionIsolationfunction currently in the concurrency library, but supported on any type of dynamically isolated function; the current API doesn't abstract over effects, ownership, etc.Once isolated captures are implemented, we can teach the actor isolation checker to recognize when a context is isolated to an actor value that came from
ExtractFunctionIsolationExprand understand that calls to the base function value do not cross an isolation boundary.