Demangle inverse requirements when building AST types #72336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For entities that must be part of the primary definition of a type, mangle without inverses on the generic parameters of the enclosing type. This ensures that we can adopt noncopyable on the generic parameters without breaking the mangling of the fundamental entities that describe the layout of the type. Do this for enum elements first, so we don't break the mangling of `Optional`. There will be other cases to consider as well.
Extend TypeDecoder with support for inverse requirements, passing them along to the type builder. Then implement support for inverse requirements within the AST demangler, which addresses the round-trip demangling failures we've been seeing. The runtime and remote inspection facilities still need metadata to deal with inverse requirements. Fixes rdar://124564447.
DougGregor
requested review from
mikeash,
al45tair,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend TypeDecoder with support for inverse requirements, passing them
along to the type builder. Then implement support for inverse
requirements within the AST demangler, which addresses the round-trip
demangling failures we've been seeing.
The runtime and remote inspection facilities still need metadata to
deal with inverse requirements.
Fixes rdar://124564447.