Skip to content

shims: adjust declaration for android NDK #72339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2024
Merged

shims: adjust declaration for android NDK #72339

merged 1 commit into from
Mar 15, 2024
+1 −1

Conversation

compnerd
Copy link
Member

Mark the nullability to repair the build against NDK r26b.

@compnerd
shims: adjust declaration for android NDK
ac4123b 
Mark the nullability to repair the build against NDK r26b.
@compnerd compnerd requested a review from a team as a code owner March 14, 2024 22:48
@compnerd
Copy link
Member Author

CC: @drodriguez @finagolfin

@compnerd
Copy link
Member Author

@swift-ci please test

finagolfin
finagolfin approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen an issue with it, but this is correct.

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd compnerd enabled auto-merge March 15, 2024 14:51
@compnerd compnerd merged commit 4c5558d into swiftlang:main Mar 15, 2024
@compnerd compnerd deleted the nullability branch March 15, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finagolfin finagolfin finagolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @finagolfin