Map package optimization flags to features #72342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
force-pushed
the
elsh/add-features
branch
2 times, most recently
from
2b6f70d to
8d86bb8
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/add-features
branch
2 times, most recently
from
896b56e to
fdd7534
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
xymus
reviewed
Mar 15, 2024
lib/Frontend/CompilerInvocation.cpp
Outdated
| Opts.SkipNonExportableDecls |= | ||
| Args.hasArg(OPT_experimental_skip_non_inlinable_function_bodies) && | ||
| Args.hasArg( | ||
| OPT_experimental_skip_non_inlinable_function_bodies_is_lazy); |
There was a problem hiding this comment.
Nitpick: it looks like the move lost the indention for these few lines.
xymus
reviewed
Mar 15, 2024
lib/Frontend/CompilerInvocation.cpp
Outdated
| @@ -2101,7 +2145,7 @@ static bool ParseSILArgs(SILOptions &Opts, ArgList &Args, | |||
| const FrontendOptions &FEOpts, | |||
| const TypeCheckerOptions &TCOpts, | |||
| DiagnosticEngine &Diags, | |||
| const llvm::Triple &Triple, | |||
| LangOptions &LangOpts, | |||
There was a problem hiding this comment.
Do I understand correctly that moving the option from Frontend to Lang was to be able to use the Features flags? I think I've hit that restriction before myself.
xymus
approved these changes
Mar 15, 2024
allow a more standard way to pass experimental features from build systems. Also moved other flags relevant to diagnostics from Frontend options to Lang options. Ref: rdar://124648653
|
@swift-ci smoke test |
tshortli
reviewed
Mar 15, 2024
lib/Frontend/CompilerInvocation.cpp
Outdated
|
|
||
| if (Args.hasArg(OPT_enable_library_evolution)) { | ||
| Opts.SkipNonExportableDecls |= | ||
| Args.hasArg(OPT_experimental_skip_non_exportable_decls); |
There was a problem hiding this comment.
Nit: PR needs clang-format
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create features mapped to package optimization flags to
allow a more standard way to pass experimental features
from build systems. Also moved other flags relevant to
diagnostics from Frontend options to Lang options.
Ref: rdar://124648653