[region-isolation] Change semantics of function_extract_isolation from AssertingIfNonSendable -> Require. #72368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m AssertingIfNonSendable -> Require. The reason why I am doing this is that: 1. function_extract_isolation can take as a parameter a non-Sendable function today in SIL so in such a case, we crash. 2. It returns an Optional<any Actor> which always must be Sendable. So it makes sense for it to just require that its non-Sendable parameter not be transferred at that point.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why I am doing this is that:
So it makes sense for it to just require that its non-Sendable parameter not be transferred at that point.