[6.0][CSSimplify] Mark all type variables in member type as holes if base is a hole #72394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is a hole Even if the member type variable is partially resolved, we still need to mark inner type variables (if any) as holes because they might not be connected to anything that could provide contextual type(s). Resolves: rdar://124549952 (cherry picked from commit b6ba3fe)
|
@swift-ci please test |
hborla
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72353
Even if the member type variable is partially resolved, we still need to mark inner type variables
(if any) as holes because they might not be connected to anything that could provide contextual type(s).
Scope: Member chains with invalid member references.
Main Branch PR: [CSSimplify] Mark all type variables in member type as holes if base … #72353
Resolves: rdar://124549952
Risk: Very Low
Reviewed By: @hborla
Testing: Added test-cases to the test suite.
Resolves: rdar://124549952
(cherry picked from commit b6ba3fe)