[region-isolation] Change named transfer non transferable error to use the dynamic merged IsolationRegionInfo found during dataflow. #72403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erTransfer. Now that we have other forms of error callbacks, having such a general name for any specific failure is misleading and hinds intent.
ActorIsolation::getActor() asserts if an actor cannot be found. This new helper method just returns nullptr instead.
…h -> PartitionUtils.h. I am going to need this so that I can use it when evaluating partition ops. Specifically, so I can when I find two values that do not merge correctly, emit an error.
…itionOpEvaluator. This will let me look up the dynamic isolation region associated with \p elt while performing dataflow.
…e the dynamic merged IsolationRegionInfo found during dataflow. I also eliminated the very basic "why is this task isolated" part of the warning in favor of the larger, better, region history impl that I am going to land soon. The diagnostic wasn't that good in the first place and also was fiddly. So I removed it for now. rdar://124960994
gottesmm
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[region-isolation] Change named transfer non transferable error to use the dynamic merged IsolationRegionInfo found during dataflow.
I also eliminated the very basic "why is this task isolated" part of the warning
in favor of the larger, better, region history impl that I am going to land
soon. The diagnostic wasn't that good in the first place and also was fiddly. So
I removed it for now.
rdar://124960994
I noticed this while fixing a different bug. To make it a little clearer, the issue is that we were emitting diagnostics where we were using the value region isolation of the immediate value which is a static flow insensitive property. Instead, we want to when we emit the error merge together all of the isolation region info of all elements in that value’s region and use that for the error. This ensures that if we merge an actor isolated thing into a task isolated thing, we emit an error saying the task isolated thing was actor isolated (since actor isolation takes precedence in the region).