Sema: Diagnose availability of storage accessors in key paths and writebacks #72410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
key-path-accessor-availability-diagnostics
branch
from
ef1e892 to
3e5bee4
Compare
tshortli
changed the title
tshortli
force-pushed
the
key-path-accessor-availability-diagnostics
branch
from
3e5bee4 to
902721a
Compare
tshortli
changed the title
|
@swift-ci please test |
xedin
approved these changes
Mar 19, 2024
Thanks! I'd like to see how it goes with an error but I'm prepared to downgrade if necessary. |
|
@swift-ci please test source compatibility |
|
Let's see if any of our source compatibility suite projects have this problem. |
I checked the results and there are no regressions (there are some known issues from non-copyable generics adoption). |
|
Great, thank you! |
Fixes the missing diagnostic about the availability of the setter of `x` in the
following example:
```
struct S {
var x: Int {
get { 0 }
@available(*, unavailable) set {}
}
}
var s = S()
s[keyPath: \.x] = 1
```
Resolves rdar://124977727
In the following example, the writeback via the property `b` should be
diagnosed since `b`'s setter is unavailable:
```
struct A {
struct B {
var x: Int = 0
}
private var _b: B = B()
var b: B {
get { _b }
@available(*, unavailable) set {
_b = newValue
}
}
}
var a = A()
a.b.x = 1
```
Resolves rdar://125019717
tshortli
force-pushed
the
key-path-accessor-availability-diagnostics
branch
from
902721a to
c7f0c58
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jun 27, 2024
The changes in swiftlang#72410 caused a regression when checking availability in the following example: ``` // warning: Setter for 'hasDeprecatedSetter' is deprecated: ... x[y.hasDeprecatedSetter] = ... ``` The result of `y.hasDeprecatedSetter` is being passed as an argument to the subscript and its setter will not be called. To fix this, `ExprAvailabilityWalker` now consistently creates a new default `MemberAccessContext` when descending into any `Argument`, since the access context for the expressions surrounding the call should not affect the arguments to the call. Additionally, `MemberAccessContext` has been refactored to better model context state transitions. Instead of only modeling which accessors will be called, the enumeration's members now reflect the possible states that `ExprAvailabilityWalker` can be in during its traversal. This should hopefully make it easier to follow the logic for traversal of `LoadExpr`s and arguments. Resolves rdar://130487998.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jun 27, 2024
The changes in swiftlang#72410 caused a regression when checking availability in the following example: ``` // warning: Setter for 'hasDeprecatedSetter' is deprecated: ... x[y.hasDeprecatedSetter] = ... ``` The result of `y.hasDeprecatedSetter` is being passed as an argument to the subscript and its setter will not be called. To fix this, `ExprAvailabilityWalker` now consistently creates a new default `MemberAccessContext` when descending into any `Argument`, since the access context for the expressions surrounding the call should not affect the arguments to the call. Additionally, `MemberAccessContext` has been refactored to better model context state transitions. Instead of only modeling which accessors will be called, the enumeration's members now reflect the possible states that `ExprAvailabilityWalker` can be in during its traversal. This should hopefully make it easier to follow the logic for traversal of `LoadExpr`s and arguments. Resolves rdar://130487998.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jun 27, 2024
The changes in swiftlang#72410 caused a regression when checking availability in the following example: ``` // warning: Setter for 'hasDeprecatedSetter' is deprecated: ... x[y.hasDeprecatedSetter] = ... ``` The result of `y.hasDeprecatedSetter` is being passed as an argument to the subscript and its setter will not be called. To fix this, `ExprAvailabilityWalker` now consistently creates a new default `MemberAccessContext` when descending into any `Argument`, since the access context for the expressions surrounding the call should not affect the arguments to the call. Additionally, `MemberAccessContext` has been refactored to better model context state transitions. Instead of only modeling which accessors will be called, the enumeration's members now reflect the possible states that `ExprAvailabilityWalker` can be in during its traversal. This should hopefully make it easier to follow the logic for traversal of `LoadExpr`s and arguments. Resolves rdar://130487998.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #72369.
Fixes the missing diagnostics about the availability of property accessors in the following examples:
Resolves rdar://124977727 and rdar://125019717