Skip to content

[6.0][Compile Time Constant Extraction] Extract macro added extensions #72425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ApolloZhu
Copy link
Contributor

Cherry-pick of #72414


Explanation: visit extension macro generated extensions to collect nominal type declarations for compile time constant extraction
Scope: compile time constant extraction where there's an attached extension macro generating an extension containing a nominal type declaration that should be extracted
Main Branch PR: #72414
Resolves: rdar://124119745
Risk: Low, additive change to compile time constant extraction only
Reviewed By: @artemcm
Testing: added test-cases to the test suite

@ApolloZhu ApolloZhu requested a review from artemcm March 19, 2024 16:44
@ApolloZhu ApolloZhu requested a review from a team as a code owner March 19, 2024 16:44
@ApolloZhu
Copy link
Contributor Author

@swift-ci please smoke test

@ApolloZhu ApolloZhu enabled auto-merge March 19, 2024 16:44
@ApolloZhu
Copy link
Contributor Author

@swift-ci please test

@ApolloZhu ApolloZhu added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels Mar 19, 2024
@artemcm artemcm requested a review from nkcsgexi March 27, 2024 16:27
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs out of regular compilation.

@ApolloZhu ApolloZhu merged commit 3823350 into release/6.0 Mar 27, 2024
@ApolloZhu ApolloZhu deleted the ApolloZhu/6.0/const-extract/extension-macro branch March 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants