[region-isolation] Convert more diagnostics from type isolation form to named variable form #72435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just chopping off parts of a larger PR that can exist independently.
In this PR, I eliminate a ton more of the cases where we failed to identify a value name resulting in us emitting a type isolation error. Example:
from,
I still need to change that specific diagnostic to use IsolationRegionInformation rather than pure callee information, but this an improvement (and more importantly just what I needed to add to do some other work). Once I am able to loop back around that would cause the note diagnostic to be transformed as follows: