[Concurrency] Don't strip @Sendable when determining the actor isolation of a closure in a @preconcurrency context.
#72437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation of a closure in a `@preconcurrency` context. Instead, downgrade any diagnostics about non-`Sendable` captures using the `.limitBehaviorUntilSwiftVersion` mechanism like other preconcurrency errors that are suppressed in minimal checking. Stripping `@Sendable` from closure types actually changes the isolation of the closure, because non-`Sendable` closures are isolated to the context they're formed in, which leads to bogus dynamic assertion failures under `-enable-actor-data-race-checks`.
|
@swift-ci please smoke test |
xedin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, downgrade any diagnostics about non-
Sendablecaptures using the.limitBehaviorUntilSwiftVersionmechanism like other preconcurrency errors that are suppressed in minimal checking. Stripping@Sendablefrom closure types actually changes the isolation of the closure, because non-Sendableclosures are isolated to the context they're formed in, which leads to bogus dynamic assertion failures under-enable-actor-data-race-checks.Resolves: rdar://125033345