[MoveOnlyAddressChecker] Fix enum representation. #72469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is long and will get longer.
The name `livenessUses` doesn't readily communicate the fact that those uses are all non-consuming.
Previously, whenever an instruction was recorded as a final consume, a new entry was added to finalBlockConsumes. Here, this is changed to add the new bits being consumed by the instruction to the preexisting SmallBitVector, if there is one.
An instruction can consume multiple (discontiguous) fields. Use a SmallBitVector to track the fields consumed by an instruction rather than a TypeTreeLeafRange. rdar://125103951
The implementation of isUsableFromInline asserts that the function not be public, so check that it's not before calling it.
Treat a take of a copyable value as a take.
nate-chandler
force-pushed
the
rdar125113258
branch
from
77bc917 to
4d2debd
Compare
jckarter
approved these changes
Mar 20, 2024
nate-chandler
force-pushed
the
rdar125113258
branch
2 times, most recently
from
daa953c to
ec2d90f
Compare
Change FieldSensitive's enum representation to allow distinguishing among the elements with associated value. Consider `unchecked_take_enum_data_addr` to consume all other fields than that taken. rdar://125113258
nate-chandler
force-pushed
the
rdar125113258
branch
from
ec2d90f to
a0a1ff2
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #72463 .
Change FieldSensitive's enum representation to allow distinguishing among the elements with associated value. Consider
unchecked_take_enum_data_addrto consume all other fields than that taken.rdar://125113258